[DON'T REVIEW] Allow underscores in numbers#4655
Closed
christianparpart wants to merge 2 commits intoargotorg:developfrom
Closed
[DON'T REVIEW] Allow underscores in numbers#4655christianparpart wants to merge 2 commits intoargotorg:developfrom
christianparpart wants to merge 2 commits intoargotorg:developfrom
Conversation
ekpyron
requested changes
Aug 2, 2018
| { | ||
| char const* sourceCode = R"( | ||
| contract test { | ||
| function f(bool cond) returns (uint) { |
Collaborator
There was a problem hiding this comment.
You're missing a public, best even a public pure here.
christianparpart
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1677
Follows https://www.python.org/dev/peps/pep-0515/
This is a recreation of the PR #3120, that got accidentally closed and couldn't be recovered (easily). My apologies, @Balajiganapathi. I however retained your original commits and will now attempt finishing them.