Merged
Conversation
axic
suggested changes
Apr 18, 2018
Contributor
axic
left a comment
axic
left a comment
There was a problem hiding this comment.
Please also include the library specific test the original issue had.
axic
force-pushed
the
betterErrorForFailedLookup
branch
from
4e33ee5 to
a94945d
Compare
axic
reviewed
Apr 18, 2018
| function g() { L.f(1, 2, 3); } | ||
| } | ||
| // ---- | ||
| // TypeError: (94-97): Member "f" not found or not visible after argument-dependent lookup in type(library L) |
Contributor
There was a problem hiding this comment.
Added this test case from the original issue.
Contributor
There was a problem hiding this comment.
A better question though: cannot we support overloads from libraries?
axic
approved these changes
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2965