Conversation
axic
reviewed
Apr 18, 2018
| m_errorReporter.warning(_function.location(), "Modifiers of functions without implementation are ignored." ); | ||
| } | ||
| if (_function.name() == "constructor") | ||
| m_errorReporter.warning(_function.location(), "This function is named \"constructor\" but is not the constructor of the contract."); |
Contributor
There was a problem hiding this comment.
I think we may want a better text here. Like the one we give when using the old-style constructor.
chriseth
force-pushed
the
warnConstructor
branch
from
efa5be8 to
cd1ec4e
Compare
Contributor
Author
|
@axic updated |
chriseth
force-pushed
the
warnConstructor
branch
from
cd1ec4e to
4895864
Compare
Contributor
Author
|
Fixed the test failure. |
axic
approved these changes
Apr 18, 2018
axic
approved these changes
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3915