Use StaticAnalyzer to deprecate msg.gas instead of conditionally remo…#3652
Merged
Use StaticAnalyzer to deprecate msg.gas instead of conditionally remo…#3652
Conversation
…ving it in MagicType.
axic
approved these changes
Mar 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ving it in MagicType.
Closes #3650.
In #3643
msg.gaswas deprecated by conditionally removing it from the MagicType in Types.cpp, resulting in an error for experimental v0.5.0, but no warning was issued when usingmsg.gaspre-v0.5.0.The only way to add such a warning I found is in the StaticAnalyzer (I realized this possibility only now - before I had not seen a good place to issue such a warning at all).
Comparing the case of
msg.gaswith, for instance, the deprecation ofcallcodein favour ofdelegatecall, I now realize that the static analyzer may have been the better choice for deprecatingmsg.gasfrom the beginning. Therefore this pull request proposes to revert parts of the changes of #3643 and instead keepsmsg.gasin MagicType, but issues a warning, resp. raises an error in the static analyzer.I think this solution is more consistent with existing code than the original solution in #3643.
Alternatively, the changes of #3634 could be left untouched, and this pull request could be reduced to issuing the warning in the static analyzer only.