Deprecate using unit denominations in combination with hex numbers.#3628
Merged
Deprecate using unit denominations in combination with hex numbers.#3628
Conversation
chriseth
reviewed
Mar 1, 2018
libsolidity/analysis/TypeChecker.cpp
Outdated
| if (v050) | ||
| m_errorReporter.fatalTypeError( | ||
| _literal.location(), | ||
| "Hexadecimal numbers cannot be used with unit denominations." |
Contributor
There was a problem hiding this comment.
We could suggest to use 0x1234 * 1 day if they really mean it.
Contributor
There was a problem hiding this comment.
Please include that to avoid user complaints 😉
…rs with unit denominations.
axic
reviewed
Mar 2, 2018
| m_errorReporter.fatalTypeError( | ||
| _literal.location(), | ||
| "Hexadecimal numbers cannot be used with unit denominations. " | ||
| "You can use an expression of the form '0x1234 * 1 day' instead." |
Contributor
There was a problem hiding this comment.
Just as a note, usually we've used double quotes for all these, i.e. form \"0x1234 * 1 day\" instead
Contributor
There was a problem hiding this comment.
@ekpyron can you please make this small change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.