Skip to content

Introduce VM version ('hard fork') column for assembly opcodes#3604

Merged
chriseth merged 3 commits intodevelopfrom
docs-update
Feb 27, 2018
Merged

Introduce VM version ('hard fork') column for assembly opcodes#3604
chriseth merged 3 commits intodevelopfrom
docs-update

Conversation

@axic
Copy link
Contributor

@axic axic commented Feb 27, 2018

No description provided.

| Perhaps it would make sense retiring this as it equals to return(0,0). It can be an optimisation by the EVM |
| backend. |
+---------------------------------------------------------------------------------------------------------------+
| | Perhaps it would make sense retiring this as it equals to |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this comment come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there. (This is the julia part.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but I still think this has no place in a documentation :)

Copy link
Contributor Author

@axic axic Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another PR which updates the builtins #3238, I'd just clean up these there and leave this single change as a formatting fix.

Note that the order of arguments can be seen to be reversed in non-functional style (explained below).
Opcodes marked with ``-`` do not push an item onto the stack, those marked with ``*`` are
special and all others push exactly one item onto the stack.
Opcodes marked with ``H``, ``B`` or ``C`` are present since Homestead, Byzantium or Constantinople, respectively.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the column has better visibility if we do not mark opcodes at all which are available even before homestead. We should also mention that constantinople is still in planning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, its only delegatecall for homestead, everything else is frontier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated (also fixed revert). Do we want to keep F for frontier or remove it?

@chriseth chriseth merged commit 9c31a0d into develop Feb 27, 2018
@axic axic deleted the docs-update branch February 27, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants