Make addmod and mulmod revert if the last argument is zero.#3523
Merged
Make addmod and mulmod revert if the last argument is zero.#3523
Conversation
chriseth
force-pushed
the
throwMulmod
branch
from
023fb72 to
c3907ab
Compare
axic
reviewed
Feb 15, 2018
| arguments[2]->accept(*this); | ||
| utils().convertType(*arguments[2]->annotation().type, IntegerType(256)); | ||
| m_context << Instruction::DUP1 << Instruction::ISZERO; | ||
| m_context.appendConditionalRevert(); |
Contributor
There was a problem hiding this comment.
Should this be revert or assert?
Contributor
There was a problem hiding this comment.
chriseth
force-pushed
the
throwMulmod
branch
from
c3907ab to
88eb269
Compare
axic
reviewed
Feb 15, 2018
Changelog.md
Outdated
| ### 0.4.21 (unreleased) | ||
|
|
||
| Features: | ||
| * Code Generator: Make ``molmod(a, b, 0)`` and ``addmod(a, b, 0)`` revert as experimental 0.5.0 feature. |
Contributor
There was a problem hiding this comment.
Need to update all the documentation changes from revert to throw (or whatever wording we're using).
chriseth
force-pushed
the
throwMulmod
branch
from
88eb269 to
2b5a5a8
Compare
axic
approved these changes
Feb 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2694