Handle git release tag properly#3288
Merged
chriseth merged 2 commits intoargotorg:developfrom Dec 6, 2017
Merged
Conversation
Build process will check current commit and if it is tagged starting with a `v` then it will create `prerelease.txt` file in the top directory.
chriseth
reviewed
Dec 6, 2017
scripts/build.sh
Outdated
| @@ -1,5 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| if [[ "$(git tag --points-at HEAD 2>/dev/null)"=="v*" ]]; then | |||
Contributor
There was a problem hiding this comment.
I think you have to add spaces around == to make this work.
Contributor
Author
There was a problem hiding this comment.
Yep, you are right. And also it should v* instead of "v*", sorry about that too. Fixed now.
chriseth
reviewed
Dec 6, 2017
scripts/build.sh
Outdated
| #!/usr/bin/env bash | ||
|
|
||
| if [[ "$(git tag --points-at HEAD 2>/dev/null)"=="v*" ]]; then | ||
| touch prerelease.txt |
Contributor
There was a problem hiding this comment.
Please make this work even if the script is run from the wrong directory. You ran for example just move the line containing cd $(dirname "$0")/.. upwards.
Contributor
Author
|
@chriseth thanks for reviewing, I've pushed review fixes |
chriseth
approved these changes
Dec 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build process will check current commit and if it is tagged
starting with a
vthen it will createprerelease.txtfile inthe top directory.