Merged
Conversation
axic
reviewed
Dec 5, 2017
| * Specific AST copier that replaces certain identifiers with expressions. | ||
| * Only works on ASTs that are expressions. | ||
| */ | ||
| class Substitution: public ASTCopier |
Contributor
There was a problem hiding this comment.
Since it works on identifiers I'd call this IndentifierSubstitution.
pirapira
approved these changes
Dec 6, 2017
Contributor
pirapira
left a comment
pirapira
left a comment
There was a problem hiding this comment.
Looks good to me.
Substitutions usually substitute identifiers.
Contributor
|
Could substitute a bunch of other things here though. Since we'll have a lot of these small steps I'd prefer clear naming, which doesn't necessarily requires someone to read every header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new AST tool for the optimizier. Please merge before everything else.