Conversation
chriseth
reviewed
Oct 19, 2017
test/RPCSession.cpp
Outdated
|
|
||
| if (connect(m_socket, reinterpret_cast<struct sockaddr const*>(&saun), sizeof(struct sockaddr_un)) < 0) | ||
| { | ||
| #if defined(_WIN32) |
Contributor
There was a problem hiding this comment.
Isn't this inside the else-part of the global if defined(_WIN32)?
axic
force-pushed
the
test-close-failure
branch
from
fd2e126 to
362615c
Compare
Contributor
Author
|
@chriseth can this be merged? |
chriseth
approved these changes
Oct 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this two different error messages are displayed if cannot connect to IPC and number of sockets is exhausted: