Allocate one byte per memory byte array element instead of 32.#3067
Merged
Allocate one byte per memory byte array element instead of 32.#3067
Conversation
chriseth
force-pushed
the
correct_byte_array_allocation
branch
from
243a37a to
dadcb48
Compare
Contributor
Author
|
@axic please review, this is short and important. |
axic
reviewed
Oct 16, 2017
| } | ||
| )"; | ||
| compileAndRun(sourceCode); | ||
| ABI_CHECK(callContractFunction("f()"), encodeArgs(0x40, 0x40, 0x20 + 256)); |
Contributor
There was a problem hiding this comment.
Just for readability perhaps go with 32 + 32, 32 + 32, 32 + 256 or 0x20 + 32 or 0x20 + 0xff.
axic
approved these changes
Oct 16, 2017
chriseth
force-pushed
the
correct_byte_array_allocation
branch
from
4a6bea0 to
21cc144
Compare
chriseth
force-pushed
the
correct_byte_array_allocation
branch
from
21cc144 to
6001bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3064