Conversation
Contributor
|
What is the boost output like in case of an exception? Do we get the exception location (file and line)? |
Contributor
Author
|
I think uncaught exceptions are reported by line. Note that we never used those macros anyway... |
Contributor
Author
|
I mean only in very special tests. |
chriseth
force-pushed
the
cleanupTestHelpers
branch
from
3507a52 to
a844bbd
Compare
Contributor
|
I mean it is useful to receive some kind of indication of the exception and if that is only possible with the old one then we should use that. I think we do get some information without those helpers so it should be fine. |
axic
approved these changes
Sep 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.