Skip to content

Remove deps git submodule#2930

Merged
chriseth merged 3 commits intodevelopfrom
no-deps-submodule
Sep 20, 2017
Merged

Remove deps git submodule#2930
chriseth merged 3 commits intodevelopfrom
no-deps-submodule

Conversation

@chfast
Copy link
Contributor

@chfast chfast commented Sep 19, 2017

No description provided.

@chriseth
Copy link
Contributor

Does the script create_source_tarball.sh still work?

@chriseth
Copy link
Contributor

also release_ppa.sh?

@chfast
Copy link
Contributor Author

chfast commented Sep 19, 2017

@chriseth I've added back the location of jsoncpp source in <source tree>/deps/downloads (so not change in this case). The create_source_tarball.sh works (I left git submodules update step, but it is noop now). I'm not sure I can test release_ppa.sh.

@chriseth
Copy link
Contributor

I'm testing the ppa

@chriseth
Copy link
Contributor

ppa seems to be working!

@chfast
Copy link
Contributor Author

chfast commented Sep 20, 2017

Merging then?

@chriseth chriseth merged commit c0b3e5b into develop Sep 20, 2017
@axic axic deleted the no-deps-submodule branch September 20, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants