Support multiple assignment in inline assembly#2924
Merged
Conversation
c5810bf to
c417846
Compare
c417846 to
1670b98
Compare
1670b98 to
042fe35
Compare
Contributor
|
Added changelog and fixed travis. |
chriseth
commented
Sep 19, 2017
Contributor
Author
chriseth
left a comment
There was a problem hiding this comment.
Wonderful, thanks!
042fe35 to
47bca53
Compare
Contributor
|
Added tests for the parser errors and managed to crash: |
Contributor
Author
|
This probably means we incorrectly estimated the stack frame size on one of the architectures. |
Contributor
|
It seems like going to a vector was enough to tip it over: - assignment.variableName = identifier;
+ assignment.variableNames.emplace_back(identifier); |
47bca53 to
0cbd6ad
Compare
axic
approved these changes
Sep 19, 2017
Contributor
|
Added more tests and fixed the stack limit for Mac. |
Contributor
Author
|
Good to merge! |
Contributor
|
This crashes on travis: |
Contributor
|
This code is triggering it: Out of this, the stack assignment ( |
0cbd6ad to
e14ab95
Compare
Contributor
Author
|
Ok, should be working now. |
Contributor
|
@chriseth please merge if tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2923.