Conversation
chriseth
approved these changes
Sep 13, 2017
chriseth
reviewed
Sep 13, 2017
| function f() external returns (bytes4) { | ||
| function () external g = this.h; | ||
| function f() view external returns (bytes4) { | ||
| function () pure external g = this.h; |
Contributor
There was a problem hiding this comment.
Hm, that's interesting. Will this be parsed correctly?
Contributor
Author
There was a problem hiding this comment.
I was wondering too but it worked, since it is parsed by the same helper.
Contributor
Author
There was a problem hiding this comment.
This is the error otherwise:
sel2.sol:5:33: Error: Type function () pure external is not implicitly convertible to expected type function () external.
function () external g = this.h;
^-----------------------------^
Contributor
There was a problem hiding this comment.
Ah, interesting. We should actually allow that conversion at some point in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #2473.