Merged
Conversation
chriseth
force-pushed
the
cleanupvectorref
branch
from
b73e72d to
b319b57
Compare
axic
reviewed
Aug 25, 2017
| for (auto const& linkRef: linkReferences) | ||
| if (h160 const* address = matchLibrary(linkRef.second, _libraryAddresses)) | ||
| address->ref().copyTo(ref(bytecode).cropped(linkRef.first, 20)); | ||
| copy(address->data(), address->data() + 20, bytecode.begin() + linkRef.first); |
Contributor
There was a problem hiding this comment.
I assume there is a test for this? (Any proper linking.)
Contributor
Author
There was a problem hiding this comment.
No special test for his, but the end-to-end-tests make heavy use of the linker.
Contributor
|
Apart from that the |
chriseth
force-pushed
the
cleanupvectorref
branch
from
b319b57 to
3f4fd7a
Compare
axic
approved these changes
Aug 25, 2017
chriseth
force-pushed
the
cleanupvectorref
branch
from
3f4fd7a to
6951a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2810 and #2809