-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Require libz3-dev for ubuntu PPA builds. #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,14 +54,24 @@ keyid=703F83D0 | |
| email=builds@ethereum.org | ||
| packagename=solc | ||
|
|
||
| for distribution in trusty vivid xenial yakkety zesty | ||
| for distribution in trusty vivid xenial zesty | ||
| do | ||
| cd /tmp/ | ||
| rm -rf $distribution | ||
| mkdir $distribution | ||
| cd $distribution | ||
|
|
||
| # Dependency | ||
| if [ $distribution = trusty -o $distribution = vivid ] | ||
| then | ||
| Z3DEPENDENCY="" | ||
| else | ||
| Z3DEPENDENCY="libz3-dev, | ||
| " | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks so weird but I guess the package format depends on it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if it is required but wanted to keep it properly indented. |
||
| fi | ||
|
|
||
| # Fetch source | ||
| git clone --recursive https://github.com/ethereum/solidity.git -b "$branch" | ||
| git clone --depth 2 --recursive https://github.com/ethereum/solidity.git -b "$branch" | ||
| mv solidity solc | ||
|
|
||
| # Fetch jsoncpp dependency | ||
|
|
@@ -102,7 +112,7 @@ Source: solc | |
| Section: science | ||
| Priority: extra | ||
| Maintainer: Christian (Buildserver key) <builds@ethereum.org> | ||
| Build-Depends: debhelper (>= 9.0.0), | ||
| Build-Depends: ${Z3DEPENDENCY}debhelper (>= 9.0.0), | ||
| cmake, | ||
| g++-4.8, | ||
| git, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaketty was removed from the ppa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu does not accept any packages for yaketty anymore.