Merged
Conversation
axic
reviewed
Aug 23, 2017
test/externalTests.sh
Outdated
| cd zeppelin-solidity | ||
| npm install | ||
| cp "$SOLJSON" ./node_modules/solc/soljson.js | ||
| ./scripts/test.sh |
axic
reviewed
Aug 23, 2017
scripts/test_emscripten.sh
Outdated
| npm run test | ||
|
|
||
| echo "Running external tests...." | ||
| "$REPO_DIR"/test/externalTests.sh "$REPO_DIR"/build/solc/soljson.js |
Contributor
There was a problem hiding this comment.
REPO_DIR? There's only REPO_ROOT in this script.
Could also create a variable for this up next to REPO_ROOT and use it in the "replacing soljson.js" part too.
Contributor
Author
There was a problem hiding this comment.
Not really sure what you mean.
chriseth
force-pushed
the
externalTests
branch
from
10a18a3 to
6a78ffe
Compare
Contributor
|
This finally works. Adds 5 minutes to the Emscripten travis time. |
axic
approved these changes
Aug 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the zeppelin tests on the current solidity version as part of the emscripten build.