Re-allow multiple modifiers per function.#2652
Merged
Conversation
Contributor
|
Tests fail |
chriseth
force-pushed
the
fixMultiModifier
branch
from
fd2bfa3 to
7c7c2ba
Compare
Contributor
Author
|
Tests should be fixed now. |
axic
reviewed
Jul 27, 2017
| Bugfixes: | ||
| * Type Checker: Fix invalid "specify storage keyword" warning for reference members of structs. | ||
| * Type Checker: Mark modifiers as internal. | ||
| * Type Checker: Re-allow multiple mentions of the same modifier per function. |
Contributor
There was a problem hiding this comment.
mentions? uses is more fitting I think? Though this is not important.
axic
reviewed
Jul 27, 2017
| solAssert(m_localVariables.count(&_declaration) && !m_localVariables[&_declaration].empty(), ""); | ||
| m_localVariables[&_declaration].pop_back(); | ||
| if (m_localVariables[&_declaration].empty()) | ||
| m_localVariables.erase(&_declaration); |
Contributor
There was a problem hiding this comment.
As far as I see this is just a memory conservation piece, it has no effect.
Contributor
Author
There was a problem hiding this comment.
I do not avoid the ambiguous situation where the declaration is present in the map as a key but is not actually a current local variable.
axic
approved these changes
Jul 27, 2017
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly fixes #2288
Fixes #2621