Skip to content

Appveyor prerelease release - PR to release branch#2232

Merged
chriseth merged 2 commits intoreleasefrom
appveyor_prerelease_release
May 4, 2017
Merged

Appveyor prerelease release - PR to release branch#2232
chriseth merged 2 commits intoreleasefrom
appveyor_prerelease_release

Conversation

@chriseth
Copy link
Contributor

@chriseth chriseth commented May 4, 2017

This is a pull request to the release branch in order to test the new code (it will also be executed for pull requests against release, not only commits on release).

@chriseth chriseth force-pushed the appveyor_prerelease_release branch from 94362f1 to 14a7454 Compare May 4, 2017 10:48
axic
axic previously approved these changes May 4, 2017
@chriseth chriseth force-pushed the appveyor_prerelease_release branch from 14a7454 to 042900a Compare May 4, 2017 11:48
@chriseth chriseth force-pushed the appveyor_prerelease_release branch from 042900a to 57a25d9 Compare May 4, 2017 12:03
@chriseth chriseth dismissed axic’s stale review May 4, 2017 14:56

Removing so this is not accidentally merged.

@chriseth
Copy link
Contributor Author

chriseth commented May 4, 2017

It did not work, windows is still reporting -nightly (all other platforms report a release build).

@chriseth
Copy link
Contributor Author

chriseth commented May 4, 2017

Had a look at the binary with a hex editor and could not find the word nightly except in an error that nightly versions are strictly less than released versions.

@chriseth chriseth merged commit 05a044e into release May 4, 2017
@axic
Copy link
Contributor

axic commented Jul 1, 2017

@chriseth does this needs to be merged into develop?

@chriseth
Copy link
Contributor Author

chriseth commented Jul 1, 2017

Eventually yes, but it is not important.

@axic axic deleted the appveyor_prerelease_release branch July 5, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants