Rewrite jsonCompiler using StandardCompiler#2213
Merged
Conversation
Contributor
Author
|
For some reason this is able to crash the fuzzer: |
Contributor
Author
|
The crash was fixed by #2263. |
axic
force-pushed
the
jsoncompiler
branch
2 times, most recently
from
72542f4 to
a86a031
Compare
Contributor
Author
|
@chriseth how do we feel about this one? Probably more tests wouldn't hurt before merging this. |
axic
force-pushed
the
jsoncompiler
branch
2 times, most recently
from
6147697 to
b418def
Compare
axic
changed the title
axic
commented
Jun 15, 2017
| // Do not taint the internal error list | ||
| ErrorList formalErrors; | ||
| ErrorReporter errorReporter(formalErrors); | ||
| if (compiler.prepareFormalAnalysis(&errorReporter)) |
Contributor
Author
There was a problem hiding this comment.
Note: this removes Why3 support.
chriseth
approved these changes
Jun 23, 2017
Contributor
chriseth
left a comment
chriseth
left a comment
There was a problem hiding this comment.
Are there any tests for this?
Contributor
Author
|
There is the |
Contributor
|
Compiled this with emscripten and ran the solc-js tests - they are green. Merging and checking in the next days if remix works with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preferably this should be merged after the 0.4.11 release.
Depends on #2114.