Conversation
chriseth
approved these changes
Mar 30, 2017
Contributor
|
An include seems to be missing, otherwise fine. |
axic
force-pushed
the
sourceformatter
branch
2 times, most recently
from
1f8858e to
0a4be88
Compare
Contributor
Author
|
@chriseth changed the CLI too. It is more clear and the new line is controlled by the caller. This reminds me that some of the newlines perhaps should be removed in SourceReferenceFormatter. |
chriseth
suggested changes
Mar 30, 2017
solc/CommandLineInterface.cpp
Outdated
| for (auto const& error: stack.second.errors()) | ||
| SourceReferenceFormatter::printExceptionInformation( | ||
| cerr, | ||
| cerr << SourceReferenceFormatter::formatExceptionInformation( |
Contributor
There was a problem hiding this comment.
Can you move all these into a helper function that adds cerr and the newline?
Contributor
Author
There was a problem hiding this comment.
I could just leave them at printExceptionInformation, that does that exactly. The reason I've changed them they were more clear to follow in the file as other messages are just dumbed to cerr.
Contributor
Author
|
@chriseth I think this can be merged |
chriseth
approved these changes
Apr 10, 2017
Contributor
|
Still not compiling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is also used byte StandardCompiler, hence another code duplication.
Additionally all the
printExceptionInformationin the CLI could be replaced, though that seems a bit backwards.