Skip to content

Conversation

@Doryu001
Copy link
Contributor

@Doryu001 Doryu001 commented Nov 2, 2025

Remove the unused isfile import and the obsolete pylint suppression from scripts/wasm-rebuild/docker-scripts/isolate_tests.py keep the required join helper so the script’s filesystem traversal remains intact let tooling surface genuine dead-import issues instead of hiding them behind suppressions

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried very hard to find a place where this is used, especially with the comment indicating that that is the case, in fact. But alas, couldn't find anything and you are absolutely right, imo such warnings shouldn't be suppressed. Thanks!

@clonker clonker merged commit 1dcc864 into argotorg:develop Nov 2, 2025
82 checks passed
@cameel cameel added the refactor label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants