Skip to content

Conversation

@clonker
Copy link
Member

@clonker clonker commented Oct 27, 2025

No description provided.

@clonker clonker force-pushed the add_arm_binaries branch 2 times, most recently from e4ce5ad to 761c414 Compare October 27, 2025 20:01
@clonker clonker requested a review from r0qs October 27, 2025 20:02
@clonker clonker marked this pull request as ready for review October 27, 2025 20:11
@clonker clonker force-pushed the add_arm_binaries branch 4 times, most recently from 09a9f51 to 1c67eaf Compare October 27, 2025 21:34
@clonker clonker force-pushed the add_arm_binaries branch 3 times, most recently from 4411675 to 1fab8cd Compare October 28, 2025 07:21
marcocastignoli

This comment was marked as outdated.

msooseth

This comment was marked as outdated.

r0qs
r0qs previously approved these changes Oct 28, 2025
@r0qs
Copy link
Member

r0qs commented Oct 28, 2025

Should we also add a section on the documentation about the arm binaries? https://github.com/argotorg/solidity/blob/8cb16a10711de9d52fcee020d609d504c1ef4abe/docs/installing-solidity.rst#static-binaries

Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some small comments, it looks good to me ;)

- b_bytecode_ems

# Final artifacts
- c_release_binaries:
Copy link
Member

@r0qs r0qs Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested c_release_binaries job and final binary produced? You could remove the on_version_tags filter and push to another branch to test it if not already.

@clonker
Copy link
Member Author

clonker commented Oct 28, 2025

Should we also add a section on the documentation about the arm binaries? https://github.com/argotorg/solidity/blob/8cb16a10711de9d52fcee020d609d504c1ef4abe/docs/installing-solidity.rst#static-binaries

It's not any different from regular linux releases, don't think it needs to be mentioned explicitly. Certainly not in a whole section. The most i'd do would be mentioning that we also support arm64 from 0.8.31

@r0qs
Copy link
Member

r0qs commented Oct 28, 2025

Should we also add a section on the documentation about the arm binaries? https://github.com/argotorg/solidity/blob/8cb16a10711de9d52fcee020d609d504c1ef4abe/docs/installing-solidity.rst#static-binaries

It's not any different from regular linux releases, don't think it needs to be mentioned explicitly. Certainly not in a whole section. The most i'd do would be mentioning that we also support arm64 from 0.8.31

Fair enough. Yeah, it would be nice to have that information somewhere indeed. But maybe having it the changelog is sufficient.

r0qs
r0qs previously approved these changes Oct 28, 2025
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approving. Since the release test should probably pass (https://app.circleci.com/pipelines/github/argotorg/solidity/40725/workflows/97daf0b8-36ae-4f4c-88c7-ad5f55a3d037). But if you think it is also good to add to the docs that we support arm64 from version 0.8.3, feel free to do so.

@r0qs r0qs self-requested a review October 28, 2025 13:36
@clonker clonker enabled auto-merge October 28, 2025 14:14
@clonker clonker merged commit 5e722e7 into develop Oct 28, 2025
81 checks passed
@clonker clonker deleted the add_arm_binaries branch October 28, 2025 14:23
@r0qs r0qs restored the add_arm_binaries branch October 31, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants