Skip to content

Conversation

@Fibonacci747
Copy link
Contributor

Fix incorrect documentation for fromHex function:

Why it was wrong:

  • Referenced non-existent type "ThrowType::DontThrow" instead of "WhenError::DontThrow"
  • Claimed function "replaces bad hex characters with 0's" which never happened

Why it's now correct:

  • Uses correct enum type "WhenError::DontThrow"
  • Accurately describes behavior: "returns an empty bytes array on any validation error"
  • Documentation now matches actual implementation and test expectations

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@clonker
Copy link
Member

clonker commented Aug 25, 2025

Thanks, it seems the docstring was a bit dated here!

@clonker clonker merged commit 29bba31 into argotorg:develop Aug 25, 2025
67 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants