refactor(formal): remove unused clear()/solver() from EncodingContext
#16164
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
| void EncodingContext::clear() | ||
| { | ||
| m_variables.clear(); | ||
| m_expressions.clear(); | ||
| m_globalContext.clear(); | ||
| m_assertions.clear(); | ||
| m_solver = nullptr; | ||
| m_accumulateAssertions = true; | ||
| resetUniqueId(); | ||
| m_state.reset(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Clearly that method was never used, it would be better to remove it entirely instead of adding unused implementation detail IMO.
| void popSolver(); | ||
| void addAssertion(smtutil::Expression const& _e); | ||
| size_t solverStackHeight() { return m_assertions.size(); } const | ||
| size_t solverStackHeight() const { return m_assertions.size(); } |
There was a problem hiding this comment.
lol this is a funny one, the const in the current version actually carries over to the next function and makes the return value pointer const (const smtutil::SolverInterface*). In any case, I dont think this (the solver method) is used anywhere, either.
phrwlk
changed the title
phrwlk
force-pushed
the
fix/formal-encoding-context-clear-const
branch
2 times, most recently
from
dcf23ec to
5b773a5
Compare
|
Ah but actually @phrwlk could you rebase again? We are avoiding merge commits on the main |
|
phrwlk
force-pushed
the
fix/formal-encoding-context-clear-const
branch
from
6daae41 to
68364ab
Compare
done |
cameel
changed the title
clear()/solver() from EncodingContext
4 participants
Remove unused EncodingContext::clear() and EncodingContext::solver() from libsolidity/formal/EncodingContext.{h,cpp}.