Conversation
| balanceOf[_to] += _value; | ||
| if (m_allowance[_from][msg.sender] >= _value && balance[_to] + _value >= balance[_to]) { | ||
| m_allowance[_from][msg.sender] -= _value; | ||
| balance[_to] += _value; |
There was a problem hiding this comment.
I think balance[_from] should be decreased.
|
Why cannot we make public accessor fulfil the method signature requirement? I.e. |
|
@axic the interface requires an external and an internal implementation. The accessor function only provides the external implementation. |
|
@axic can this be merged? |
I would have assumed it provides both the internal and the external interface. Isn't that a bug in that case? |
|
No, internally, you get a storage variable and not a function that returns the value of the storage variable. |
|
@axic Please note that this particular PR just fixes the token so that it compiles again. This is unrelated to the decision about whether or not public storage variables are considered implementors of public functions. |
Fixes #1480