-
Notifications
You must be signed in to change notification settings - Fork 6.3k
release checklist: mention buildx as requirement for docker_deploy_manual #15930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also have added it in the Requirements part on top instead (although that's less likely to be read - although you also only need to be aware of this once :-))
738c53a to
da50504
Compare
Alright, yeah, fair enough :) I guess it is fine to not mention gnu core utilities, git, and bash as explicit dependencies :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok apart from some very minor inconsistencies.
ReleaseChecklist.md
Outdated
| - [ ] Update the version and the hash (``sha256sum solidity_$VERSION.tar.gz``) in the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/solidity.rb). | ||
|
|
||
| ### Docker | ||
| - [ ] Make sure `docker-buildx` is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [ ] Make sure `docker-buildx` is installed. | |
| - [ ] Make sure ``docker-buildx`` is installed. |
Though I'd also be fine with refactoring this file in a separate PR to switch to single backticks and end this insanity :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's end it :) I'll prepare a PR tomorrow (or rather: later today)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also do that with the CHANGELOG. I would not go as far as to reformat the older entries (git blame is really useful there and that would make it more annoying to use) but I think it would be fine to just switch to the new style from now on since we just released and the changelog for the new release is empty. We could also drop the annoying space before the bullet point, which people keep removing (understandably, since it's a weird way to do it).
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, absolutely for it. It is a bit annoying that we get an inconsistent style with older entries but on the other hand it is a clean cut and more sensible from now on. :)
da50504 to
7de336d
Compare
7de336d to
c84cac8
Compare
No description provided.