Skip to content

Conversation

@clonker
Copy link
Member

@clonker clonker commented Mar 12, 2025

No description provided.

ekpyron
ekpyron previously approved these changes Mar 12, 2025
Copy link
Collaborator

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also have added it in the Requirements part on top instead (although that's less likely to be read - although you also only need to be aware of this once :-))

@clonker clonker force-pushed the mention-buildx-dep-in-release-checklist branch from 738c53a to da50504 Compare March 12, 2025 11:03
@clonker
Copy link
Member Author

clonker commented Mar 12, 2025

Could also have added it in the Requirements part on top instead (although that's less likely to be read - although you also only need to be aware of this once :-))

Alright, yeah, fair enough :) I guess it is fine to not mention gnu core utilities, git, and bash as explicit dependencies :D

cameel
cameel previously approved these changes Mar 13, 2025
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok apart from some very minor inconsistencies.

- [ ] Update the version and the hash (``sha256sum solidity_$VERSION.tar.gz``) in the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/solidity.rb).

### Docker
- [ ] Make sure `docker-buildx` is installed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Make sure `docker-buildx` is installed.
- [ ] Make sure ``docker-buildx`` is installed.

Though I'd also be fine with refactoring this file in a separate PR to switch to single backticks and end this insanity :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's end it :) I'll prepare a PR tomorrow (or rather: later today)

Copy link
Collaborator

@cameel cameel Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also do that with the CHANGELOG. I would not go as far as to reformat the older entries (git blame is really useful there and that would make it more annoying to use) but I think it would be fine to just switch to the new style from now on since we just released and the changelog for the new release is empty. We could also drop the annoying space before the bullet point, which people keep removing (understandably, since it's a weird way to do it).

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, absolutely for it. It is a bit annoying that we get an inconsistent style with older entries but on the other hand it is a clean cut and more sensible from now on. :)

@cameel cameel force-pushed the mention-buildx-dep-in-release-checklist branch from da50504 to 7de336d Compare March 13, 2025 23:18
@clonker clonker force-pushed the mention-buildx-dep-in-release-checklist branch from 7de336d to c84cac8 Compare March 13, 2025 23:31
@clonker clonker merged commit bf51113 into develop Mar 14, 2025
74 checks passed
@clonker clonker deleted the mention-buildx-dep-in-release-checklist branch March 14, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants