eof: Disallow EOF builtins in inline assembly. #15783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
cameel
previously approved these changes
Jan 27, 2025
|
Looks like tests fail because this was affected by #15784. So no changes needed here - it should just be merged after it. |
rodiazet
force-pushed
the
disallow-eof-builtins-in-assembly
branch
from
85f994c to
8e7ee48
Compare
|
#15784 merged. Please rebase. You'll have to update the test expectations before we can merge though (you could have left them unchanged like I said above). |
rodiazet
force-pushed
the
disallow-eof-builtins-in-assembly
branch
from
8e7ee48 to
677c84a
Compare
|
It was rebased on #15784. So tests should be fine. |
cameel
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs disallows eof builtins in solidity inline assembly statement. It has to be properly designed in the language level how to allow developers to use them. It should be allowed back when it's done.
Depends on:
#15784Merged