eof: Test that EOF sets the experimental flag in metadata#15663
Merged
cameel merged 1 commit intoargotorg:developfrom Jan 30, 2025
Merged
eof: Test that EOF sets the experimental flag in metadata#15663cameel merged 1 commit intoargotorg:developfrom
experimental flag in metadata#15663cameel merged 1 commit intoargotorg:developfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
cameel
reviewed
Dec 19, 2024
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
We should make the test use settings from command-line like other metadata tests already do. Other than that the test seems ok.
cameel
changed the title
experimental flag in metadata
Collaborator
|
This one needs rebase. And only small adjustments so we we should be able to merge it easily. |
rodiazet
force-pushed
the
eof-flag-set-test
branch
3 times, most recently
from
5cc7d85 to
e8e2e43
Compare
cameel
previously approved these changes
Jan 29, 2025
… experimental flag being set.
rodiazet
force-pushed
the
eof-flag-set-test
branch
from
e8e2e43 to
f580dfb
Compare
cameel
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test which checks that setting an EOF version results in the experimental flag being set.