eof: objectCompiler tests updating#15662
Merged
cameel merged 1 commit intoargotorg:developfrom Feb 1, 2025
Merged
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
This comment was marked as resolved.
This comment was marked as resolved.
cameel
reviewed
Jan 29, 2025
test/libyul/objectCompiler/eof/identical_subobjects_creation_deployed.yul
Outdated
Show resolved
Hide resolved
cameel
reviewed
Jan 29, 2025
rodiazet
force-pushed
the
eof-object-compiler-tests-update
branch
3 times, most recently
from
4849556 to
e254feb
Compare
cameel
added
has dependencies
rodiazet
force-pushed
the
eof-object-compiler-tests-update
branch
from
e254feb to
ecac5a8
Compare
cameel
previously approved these changes
Jan 31, 2025
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Looks good overall so approving.
Maybe we could still add an EOF version of one test that turned out to be impossible to make portable (#15662 (comment)).
rodiazet
force-pushed
the
eof-object-compiler-tests-update
branch
2 times, most recently
from
8a4b368 to
4f12ce2
Compare
rodiazet
force-pushed
the
eof-object-compiler-tests-update
branch
from
4f12ce2 to
8fc863d
Compare
cameel
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eoffolderDepends on #15803Merged