A script to summarize gas differences from isoltest for PRs. #11498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
approved these changes
Jun 8, 2021
Collaborator
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
There's a few things that would be nice to have for this:
- Comparing legacy vs ir optimized.
- Comparing between arbitrary branches.
- Distinguishing between code size cost and runtime gas cost (that would first need support in the isoltest expectations and emitted there, though - but that should actually be feasible to do there and generally be nice).
But none of it is too important and it's nice to have as is as well :-).
| Note that the changes to semantic tests have to be committed. | ||
|
|
||
| Assumes that there is a remote named ``origin`` pointing to the Solidity github | ||
| repository. The changes are compared against ``origin/develop``. |
Collaborator
There was a problem hiding this comment.
If anyone ever has too much time, it'd be nice to have an optional argument for this that just defaults to origin/develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.