Remove unneeded include files #11491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
reviewed
Jun 7, 2021
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
Looks good!
At first I thought this might be removing a bit too much, i.e. headers for stuff that's actually used in the file but also included via another header. In practice I only found one instance of this (GasMeter.h) and most of the removed includes seem pretty generic so I think it's a net improvement even if there happen to be more cases like this.
Marenz
reviewed
Jun 7, 2021
Contributor
Marenz
left a comment
Marenz
left a comment
There was a problem hiding this comment.
LGTM. Will change to approved when cameels comments are taken care of :)
Contributor
|
@TerranCivilian can you squash all the commits into one? |
Contributor
Author
|
Yes sir, right away sir |
chriseth
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLion's code inspection raised a few false alarms that broke compilation; I had to painstakingly weed them out. Everything else was removed without issue.