Skip to content

Conversation

@chriseth
Copy link
Contributor

@chriseth chriseth commented Jun 3, 2021

Fixes #10620

I'm still a bit puzzled why the bug does not manifest in

abstract contract A {
    function f() public view mod {
        //uint x = 2;
        require(block.timestamp > 10);
    }
    modifier mod() virtual;
}

(the require statement is essential for the bug to trigger)

So maybe this is not the right fix.

@chriseth chriseth requested a review from ekpyron June 3, 2021 11:14
@chriseth chriseth enabled auto-merge June 3, 2021 14:55
Copy link
Collaborator

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could get a bugfix changelog entry, but the fix is fine in any case.

@chriseth chriseth merged commit a8ffa6c into develop Jun 3, 2021
@chriseth chriseth deleted the fixUnreachable2 branch June 3, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect warning about unreachable code.

3 participants