Skip to content

Bump docker images for z3 4.8.10 #10844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2021
Merged

Bump docker images for z3 4.8.10 #10844

merged 1 commit into from
Jan 26, 2021

Conversation

@leonardoalt
Copy link

@leonardoalt leonardoalt commented Jan 25, 2021 •
edited
Loading

Once the images are built, their hashes will be used by the PR that updates the tests.

This was referenced Jan 25, 2021
Merged
Merged
@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:72373355f5c85641934ed43383316cf78dd05f145ce7e817c1390d9db980dec6].

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:e8669c1b90a6a3b4e5bd583c8e6059c4bb1e4964ef4a408cf0f63aec933d80ca].

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:emscripten-4 [solbuildpackpusher/solidity-buildpack-deps@sha256:6bd1b8e06bab51d72e9489d9d9772234c4486ae42a4a4c60a5a2a1899d3143ec].

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu1604.clang.ossfuzz-8 [solbuildpackpusher/solidity-buildpack-deps@sha256:3863d11fc935445d61e97146e6a4f23847308c1870f57c342b04ffe8b69325bc].

cameel
cameel previously approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. The archlinux test job is failing because CI is still using the old images with Z3 4.8.9, right?

@leonardoalt
Copy link
Author

leonardoalt commented Jan 25, 2021

@cameel nop, arch installs directly from pacman which has 4.8.10, it fails because the tests weren't updated.
Actually I think I ran this too quickly... the ppa builds must be finished to have an effect on the ubuntu builds, they should fail with the old tests and new z3.

@leonardoalt
Copy link
Author

leonardoalt commented Jan 25, 2021

Ah no, the images are fine. I need to copy the hashes in the comments here into #10845, and the tests should pass there. Only after merging that we should merge this one.

@cameel cameel dismissed their stale review January 25, 2021 13:17

#10845 needs to pass tests first after all.

@leonardoalt leonardoalt changed the base branch from develop to smt_z3_4-8-10 January 25, 2021 13:18
@leonardoalt leonardoalt force-pushed the smt_z3_4-8-10 branch 2 times, most recently from 874f9df to 5ba21c7 Compare January 25, 2021 14:19
@leonardoalt leonardoalt force-pushed the smt_z3_docker_4_18_10 branch from 2badaae to d416d05 Compare January 25, 2021 15:10
@leonardoalt leonardoalt changed the base branch from smt_z3_4-8-10 to develop January 25, 2021 16:20
@leonardoalt leonardoalt force-pushed the smt_z3_docker_4_18_10 branch from d416d05 to 5c76697 Compare January 25, 2021 16:21
@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:4fbc7a99dd0b204fef587856d89640e4b2060d459ba15c32b89733b2a6054d7f].

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-5 [solbuildpackpusher/solidity-buildpack-deps@sha256:2d306b8da3485c2584a8868d656dc36c1ae50f003ff085ad2e904e312534b9b7].

bshastry
bshastry reviewed Jan 25, 2021
View reviewed changes
scripts/docker/buildpack-deps/Dockerfile.ubuntu2004.clang
#------------------------------------------------------------------------------
FROM buildpack-deps:focal AS base
LABEL version="4"
LABEL version="5"
Copy link
Contributor

@bshastry bshastry Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:ubuntu1604.clang.ossfuzz-8 [solbuildpackpusher/solidity-buildpack-deps@sha256:42f47b7ddafbf57b4e48357022cf34dc38ae477b05ddc2210e7ed68d821c2019].

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

solbuildpackpusher/solidity-buildpack-deps:emscripten-4 [solbuildpackpusher/solidity-buildpack-deps@sha256:434719d8104cab47712dd1f56f255994d04eb65b802c0d382790071c1a0c074b].

bshastry
bshastry previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@bshastry bshastry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing test should pass in the other PR but better to update that PR with the docker image hash published by the bot in that PR and verify this before merging this PR.

@leonardoalt leonardoalt force-pushed the smt_z3_docker_4_18_10 branch from 5c76697 to fbfcb4e Compare January 26, 2021 10:38
cameel
cameel approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge as soon as tests pass.

@leonardoalt
Copy link
Author

leonardoalt commented Jan 26, 2021

I'm slightly worried that the docker images are being built again, this shouldn't be the case... if it is, the hashes are gonna be different and we'll have to do the other PR again

@cameel
Copy link
Collaborator

cameel commented Jan 26, 2021

Ah, right. That's because you rebased it. They will almost certainly be different unless it's using Docker's cache (and I don't think it is because the build machine is not persistent).

I remember that last time @aarlt was updating the images, he put the PR using the hashes on top of the one building the images. Looks like that was a better strategy.

Anyway, the images that were already built should be good so I think all tests will pass anyway, even if you do not take the new hashes.

@leonardoalt
Copy link
Author

leonardoalt commented Jan 26, 2021

Yea, I cancelled the new builds so we don't have trash lying around, but should be good

@leonardoalt leonardoalt merged commit c35fdda into develop Jan 26, 2021
@leonardoalt leonardoalt deleted the smt_z3_docker_4_18_10 branch January 26, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameel cameel cameel approved these changes

+1 more reviewer

@bshastry bshastry bshastry left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leonardoalt @cameel @bshastry