Bytecode comparison via CLI interface #10676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
0f67e2f to
5551f4d
Compare
cameel
force-pushed
the
refactor-bytecode-comparison-scripts
branch
from
170e193 to
efe25ba
Compare
cameel
force-pushed
the
cli-bytecode-comparison
branch
2 times, most recently
from
1d1294c to
fd6e67a
Compare
This was referenced Dec 22, 2020
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
ca9fd0d to
98fbf61
Compare
Base automatically changed from
refactor-bytecode-comparison-scripts
to
develop
January 11, 2021 17:57
leonardoalt
reviewed
Jan 12, 2021
cameel
force-pushed
the
cli-bytecode-comparison
branch
2 times, most recently
from
d426e3b to
0870d13
Compare
This was referenced Jan 19, 2021
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
d0b3402 to
429c711
Compare
|
@cameel bytecode comparison is failing though |
Collaborator
Author
|
Yeah, I know. I'm working on a fix: #10822. Anyway, I'm switching this PR to draft mode. It can be reviewed but I'm still working on resolving minor issues so it's not mergable yet. |
cameel
force-pushed
the
cli-bytecode-comparison
branch
4 times, most recently
from
9f115ef to
5f41135
Compare
cameel
force-pushed
the
python-unit-tests-in-ci
branch
from
4465e6e to
8c88bb0
Compare
cameel
force-pushed
the
cli-bytecode-comparison
branch
3 times, most recently
from
b5951da to
eb081ad
Compare
cameel
force-pushed
the
python-unit-tests-in-ci
branch
3 times, most recently
from
564f963 to
cf147fa
Compare
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
eb081ad to
5e70dd1
Compare
Collaborator
Author
|
Bytecode comparison problems have been resolved so this is now ready. |
cameel
force-pushed
the
cli-bytecode-comparison
branch
3 times, most recently
from
8d34c08 to
dd95291
Compare
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
dd95291 to
3b03bc7
Compare
leonardoalt
reviewed
Jan 26, 2021
leonardoalt
left a comment
leonardoalt
left a comment
There was a problem hiding this comment.
lgtm but it would be good to have another pair of eyes on the python code
|
Also please rebase |
… JSON compiler interfaces
…rrors, not missing bytecode
cameel
force-pushed
the
cli-bytecode-comparison
branch
from
3b03bc7 to
53f9a11
Compare
Collaborator
Author
|
Rebased. I thought I rebased it just after the Z3 4.8.10 merge but it must have been a little too early :) |
chriseth
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4698.
Depends on #10819. Don't merge until that PR is merged!.It's ondevelopnow.This PR adds
--interfaceoption toprepare_report.pyto allow selecting between doing the compilation via Standard JSON or via the ordinary CLI interface.It also modifies the existing CI jobs to create both versions of the report to make sure they're identical.