-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Closed as not planned
Labels
closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.medium effortDefault level of effortDefault level of effortshould haveWe like the idea but it’s not important enough to be a part of the roadmap.We like the idea but it’s not important enough to be a part of the roadmap.solcbinstaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.testing 🔨
Description
To avoid problems like #11358 we should make the bytecode check script (#10838) cross-platform and start running the check on Windows binaries as well.
In #10838 I added a bytecode check for old releases in solc-bin. The goal was to verify the rebuilt macOS binaries. I thought it would be a waste not to reuse in some way it so I also hooked it up as a PR check for newly added binaries but this was just a low priority side-task and spending more time to get it to run on Windows as well did not seem like a good idea. It's a bash script so it will likely not run out of the box on Windows, though we could try our luck with bash.exe. A more robust alternative would be to rewrite it in Python.
Metadata
Metadata
Assignees
Labels
closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.medium effortDefault level of effortDefault level of effortshould haveWe like the idea but it’s not important enough to be a part of the roadmap.We like the idea but it’s not important enough to be a part of the roadmap.solcbinstaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.testing 🔨