Checking if type variables are unbound in class and instance definitions #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodrigo Ribeiro <rodrigogribeiro@gmail.com>
Signed-off-by: Rodrigo Ribeiro <rodrigogribeiro@gmail.com>
Signed-off-by: Rodrigo Ribeiro <rodrigogribeiro@gmail.com>
rodrigogribeiro
changed the title
mbenke
approved these changes
Dec 22, 2025
Collaborator
mbenke
left a comment
mbenke
left a comment
There was a problem hiding this comment.
Well done, just a few nits.
Comment on lines
807
to
809
| let unbound_vars = (bv idef) \\ vs | ||
| unless (null unbound_vars) $ do | ||
| unboundTypeVars idef unbound_vars |
Collaborator
There was a problem hiding this comment.
Code duplication with the similar change in TcContract and also in checkSignature. Consider
checkAllTypeVarsBound :: Pretty a => a -> [Tyvar] -> [Tyvar] -> TcM ()
checkAllTypeVarsBound context used declared =
let unbound = used \\ declared
in unless (null unbound) $ unboundTypeVars context unbound
Then use:
-- In checkClass:
checkAllTypeVarsBound icls (v : vs) bvs
-- In checkInstance:
checkAllTypeVarsBound idef (bv idef) vs
-- In checkSignature:
checkAllTypeVarsBound sig (v : vs) bvs
Collaborator
Author
There was a problem hiding this comment.
Fixed in the latest commit. Thanks for the suggestion!
Signed-off-by: Rodrigo Ribeiro <rodrigogribeiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240.