Remove the workaround for greedy exception catcher#569
Closed
Conversation
…ption - This has been fixed in the emscripten binaries
Collaborator
Author
|
@axic #174 (comment) says we can safely remove it but won't that break on pre-0.4.20 binaries? Well, wasm rebuilds were done long after 0.4.20 so I think they do not have this problem and also the change only affects the |
Contributor
|
Actually we probably can't remove it if we want to keep supporting old compiler versions with this CLI tool. Those binaries still need it 😢 |
Collaborator
Author
|
Oh well, I was afraid that this would be the end result. Yeah, I think we want to support them, I guess there's no magic way to do it without this workaround :) I'm closing it then. We can always revive if we decide to merge it after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old workaround that was added in #34 to solve chriseth/browser-solidity#167.
The issue was solved properly by adding
NODEJS_CATCH_EXIT=0flag to our emscripten build in 0.4.20 (argotorg/solidity#3477). According to #174 (comment) the workaround is no longer needed.