Skip to content

Use outputSelection in jsonio tests#159

Merged
chriseth merged 1 commit intomasterfrom
jsonio-test
Oct 19, 2017
Merged

Use outputSelection in jsonio tests#159
chriseth merged 1 commit intomasterfrom
jsonio-test

Conversation

@axic
Copy link
Contributor

@axic axic commented Oct 19, 2017

No description provided.

@axic
Copy link
Contributor Author

axic commented Oct 19, 2017

@chriseth can this be merged?

@chriseth
Copy link
Contributor

Wouldn't it be better to request everything in most tests and only have some test that only request the bytecode?

@axic
Copy link
Contributor Author

axic commented Oct 19, 2017

I had '*' before but that is not included in the docs (yet) and all the tests only care about evm.bytecode so I've figured the tests will be faster this way (once implemented properly).

@chriseth
Copy link
Contributor

ok sure, but do we at least have tests that request everything?

@axic
Copy link
Contributor Author

axic commented Oct 19, 2017

Not here, we have them in Solidity.

@chriseth chriseth merged commit 9e9562a into master Oct 19, 2017
@axic axic deleted the jsonio-test branch October 19, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants