Use the right head ref in bytecode PR check #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refer to the PR branch.
cameel
force-pushed
the
use-correct-head-ref-in-bytecode-pr-check
branch
from
1d9d26f to
9174730
Compare
This was referenced May 10, 2021
chriseth
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github's docs on Environment Variables say:
Turns out this is not completely true. For example PR #90 is failing CI checks because
GITHUB_REFisrefs/pull/90/mergewhich is neither a tag nor a branch:This PR replaces it with
GITHUB_HEAD_REFwhich is hopefully what we need. This problem went undetected until now because of argotorg/solidity#11189 and because locally I only tested the script with actual branch names.