Google #49
Merged
Google #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
Signed-off-by: Francílio Araújo <francilioaraujo@gmail.com>
…gine into google # Conflicts: # pkg/services/services.go
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 47.04% 47.51% +0.47%
==========================================
Files 28 29 +1
Lines 1605 1671 +66
==========================================
+ Hits 755 794 +39
- Misses 683 698 +15
- Partials 167 179 +12
Continue to review full report at Codecov.
|
Signed-off-by: pashavictorovich <pavel@codefresh.io>
pasha-codefresh
force-pushed
the
google
branch
from
5a73574 to
3680b82
Compare
|
Original PR is here It is just delivery of this PR |
alexmt
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Thanks for resolving merge conflicts @pasha-codefresh
And big thanks to @francilioaraujo for implementing the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivery for #45