feat: add Prune as application level sync option #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
MrFreezeex
force-pushed
the
require-pruning-confirmation-syncoption
branch
from
d9429e6 to
e88193f
Compare
MrFreezeex
changed the title
MrFreezeex
changed the title
pjiang-dev
approved these changes
Jun 13, 2025
MrFreezeex
force-pushed
the
require-pruning-confirmation-syncoption
branch
from
e88193f to
13f9343
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 54.26% 47.54% -6.73%
==========================================
Files 64 64
Lines 6164 6575 +411
==========================================
- Hits 3345 3126 -219
- Misses 2549 3193 +644
+ Partials 270 256 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
(note that I only changed the second commit title that was point at the wrong sync option before :x) |
MrFreezeex
force-pushed
the
require-pruning-confirmation-syncoption
branch
2 times, most recently
from
03789b8 to
7f8ccfc
Compare
agaudreault
requested changes
Jun 17, 2025
MrFreezeex
force-pushed
the
require-pruning-confirmation-syncoption
branch
3 times, most recently
from
b8b3241 to
a37aef2
Compare
Add WithRequiresPruneConfirmation so that we can pass this as an Application sync option in ArgoCD Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr>
MrFreezeex
force-pushed
the
require-pruning-confirmation-syncoption
branch
from
a37aef2 to
a1d18d9
Compare
|
Thanks @agaudreault! I added some unit test for Prune=false and Prune=confirm, the latter didn't had any so far so I added some for Prune=confirm on a resource directly too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to argoproj/argo-cd#23370 / argoproj/argo-cd#23380