Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added Proposal-Template #9857

Closed
wants to merge 3 commits into from
Closed

docs: Added Proposal-Template #9857

wants to merge 3 commits into from

Conversation

sarabala1979
Copy link
Member

Fixes #TODO

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@sarabala1979
chore: Added Proposal-Template
95c2c56 
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@sarabala1979
chore: update
d68aad1 
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@sarabala1979 sarabala1979 changed the title chore: Added Proposal-Template docs: Added Proposal-Template Oct 18, 2022
@sarabala1979 sarabala1979 marked this pull request as ready for review October 18, 2022 17:27
sarabala1979
sarabala1979 commented Oct 18, 2022
View reviewed changes
docs/proposals/001_PROPOSAL-TEMPLATE.md
@@ -0,0 +1,111 @@
---
title: Neat-enhancement-idea
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from Argocd

@alexec
Copy link
Contributor

alexec commented Oct 29, 2022

Build needs fixing.

@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Nov 12, 2022
@stale
Copy link

stale bot commented Nov 23, 2022

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Nov 23, 2022
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Jan 10, 2024
@agilgur5 agilgur5 mentioned this pull request Jan 19, 2024
Open
@agilgur5 agilgur5 added the solution/unimplemented This was not implemented, but may be in the future label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/docs Incorrect, missing, or mistakes in docs problem/stale This has not had a response in some time solution/unimplemented This was not implemented, but may be in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarabala1979 @alexec @terrytangyuan @agilgur5