Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): server logs to be structured and add more log error #2308 #9779

Merged
merged 18 commits into from
Oct 10, 2022
Merged

feat(server): server logs to be structured and add more log error #2308 #9779

merged 18 commits into from
Oct 10, 2022

Conversation

VUHAILAM
Copy link
Contributor

@VUHAILAM VUHAILAM commented Oct 9, 2022 •
edited
Loading

#2308
Signed-off-by: Lam Vu lamvh2812@gmail.com

Rewrite log into a structured form suggested in #2308
Add more error log for workflow server

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

feat(server): server logs to be structured and add more log error
defc663 
Signed-off-by: Lam Vu <lamvh2812@gmail.com>
Signed-off-by: Lam Vu <lvu@axon.com>
@VUHAILAM VUHAILAM force-pushed the feature/structure-log-server branch from 0a53895 to defc663 Compare October 9, 2022 17:12
Delete v3 folder
82e7d55 
Signed-off-by: Lam Vu <lvu@axon.com>
@VUHAILAM VUHAILAM changed the title feat(server): server logs to be structured and add more log error feat(server): server logs to be structured and add more log error https://github.com/argoproj/argo-workflows/issues/2308 Oct 9, 2022
@VUHAILAM VUHAILAM changed the title feat(server): server logs to be structured and add more log error https://github.com/argoproj/argo-workflows/issues/2308 feat(server): server logs to be structured and add more log error Oct 9, 2022
@VUHAILAM VUHAILAM changed the title feat(server): server logs to be structured and add more log error feat(server): server logs to be structured and add more log error #2308 Oct 9, 2022
Lam Vu added 4 commits October 10, 2022 02:07
Fix lint
9c700f5 
Signed-off-by: Lam Vu <lvu@axon.com>
Fix lint
02227b0 
Signed-off-by: Lam Vu <lvu@axon.com>
Re-run job
9ce693f 
Signed-off-by: Lam Vu <lvu@axon.com>
Re-run job
52078a2 
Signed-off-by: Lam Vu <lvu@axon.com>
@VUHAILAM VUHAILAM marked this pull request as ready for review October 9, 2022 20:14
@VUHAILAM VUHAILAM mentioned this pull request Oct 9, 2022
Open
alexec
alexec requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While most of the changes are good, I don't think we should log then return errors. This could result in double logging, or logging when we're not expecting it (e.g. in the cli).

server/clusterworkflowtemplate/cluster_workflow_template_server.go Outdated Show resolved Hide resolved
VUHAILAM and others added 11 commits October 10, 2022 23:12
@VUHAILAM
Merge branch 'master' into feature/structure-log-server
97a973b
@VUHAILAM
Merge branch 'master' into feature/structure-log-server
9df696b
feat(server): server logs to be structured and add more log error
f42f871 
Signed-off-by: Lam Vu <lamvh2812@gmail.com>
Signed-off-by: Lam Vu <lvu@axon.com>
Delete v3 folder
07e7ae9 
Signed-off-by: Lam Vu <lvu@axon.com>
Fix lint
fc66605 
Signed-off-by: Lam Vu <lvu@axon.com>
Fix lint
a556c26 
Signed-off-by: Lam Vu <lvu@axon.com>
Re-run job
a76ae21 
Signed-off-by: Lam Vu <lvu@axon.com>
Re-run job
2017fff 
Signed-off-by: Lam Vu <lvu@axon.com>
Remove redundant error log
201e142 
Signed-off-by: Lam Vu <lvu@axon.com>
Merge branch 'feature/structure-log-server' of https://github.com/VUH…
725355c 
…AILAM/argo-workflows into feature/structure-log-server
Remove redundant log
25453d4 
Signed-off-by: Lam Vu <lvu@axon.com>
@VUHAILAM VUHAILAM requested a review from alexec October 10, 2022 16:46
@alexec alexec enabled auto-merge (squash) October 10, 2022 17:23
@alexec alexec merged commit 514aa05 into argoproj:master Oct 10, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@VUHAILAM @juchaosong
feat(server): server logs to be structured and add more log error arg…
47828bf 
…oproj#2308 (argoproj#9779)

Signed-off-by: Lam Vu <lamvh2812@gmail.com>
Signed-off-by: Lam Vu <lvu@axon.com>
Co-authored-by: Lam Vu <lvu@axon.com>
Signed-off-by: juchao <juchao@coscene.io>
@terrytangyuan terrytangyuan mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VUHAILAM @alexec @agilgur5