feat: log format option for wait and init containers. Fixes #8986 #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 2, 2022
* feat: log format option for main containers adds --log-format and --loglevel flags to "argoexec emissary" for consistent logging output. related to: #8986 #9169 #7361 Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> * update tests Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> * update tests Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
* feat: log format option for main containers adds --log-format and --loglevel flags to "argoexec emissary" for consistent logging output. related to: argoproj#8986 argoproj#9169 argoproj#7361 Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> * update tests Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> * update tests Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> Signed-off-by: Thomas Bonfort <thomas.bonfort@airbus.com> Signed-off-by: juchao <juchao@coscene.io>
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 2, 2023
…8986 (argoproj#9169) * feat: log format option for wait and init containers. Fixes argoproj#8986 (argoproj#1) related to: argoproj#7361 fixes argoproj#8986 Signed-off-by: Hunter-Thompson <aatman@auroville.org.in> * fix: use log-format arg instead of creating executor-log-format Signed-off-by: Hunter-Thompson <aatman@auroville.org.in> Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #7361
fixes #8986
TODO: add test
Signed-off-by: Hunter-Thompson aatman@auroville.org.in