Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add upgrading guide for TLS metrics for 3.3 #7051

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

simster7
Copy link
Member

Related to: #7041

Signed-off-by: Simon Behar simbeh7@gmail.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@@ -6,7 +6,11 @@ the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summar

## Upgrading to v3.3

## feat(server)!: Sync dispatch of webhook events by default
### [TODO: add commit once PR is merged] feat: Add TLS to Metrics and Telemetry servers (#7041)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add commit once #7041 is merged

@sarabala1979 sarabala1979 enabled auto-merge (squash) October 25, 2021 16:31
@simster7
Copy link
Member Author

Do not merge before #7041

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #7051 (0f95790) into master (31bf57b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7051      +/-   ##
==========================================
+ Coverage   48.48%   48.52%   +0.04%     
==========================================
  Files         265      265              
  Lines       19307    19307              
==========================================
+ Hits         9361     9369       +8     
+ Misses       8889     8882       -7     
+ Partials     1057     1056       -1     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.29% <0.00%> (+0.14%) ⬆️
cmd/argo/commands/get.go 59.18% <0.00%> (+0.29%) ⬆️
workflow/controller/workflowpod.go 74.41% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bf57b...0f95790. Read the comment docs.

@alexec alexec merged commit 3d6f12d into argoproj:master Oct 27, 2021
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/metrics labels Jun 30, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Jun 30, 2024
@agilgur5 agilgur5 added type/security Security related area/controller Controller issues, panics labels Jun 30, 2024
@agilgur5 agilgur5 changed the title docs: Add upgrading guide for TLS metrics docs: Add upgrading guide for TLS metrics for 3.3 Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/controller Controller issues, panics area/docs Incorrect, missing, or mistakes in docs area/metrics type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants