Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document default values for the environment variables #6087

Merged
merged 1 commit into from
Jun 4, 2021
Merged

docs: Document default values for the environment variables #6087

merged 1 commit into from
Jun 4, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

Tips:

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #6087 (2612ae3) into master (eddd420) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 2612ae3 differs from pull request most recent head 0e02441. Consider uploading reports for the commit 0e02441 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
- Coverage   47.69%   47.63%   -0.07%     
==========================================
  Files         249      249              
  Lines       15737    15737              
==========================================
- Hits         7506     7496      -10     
- Misses       7295     7303       +8     
- Partials      936      938       +2     
Impacted Files Coverage Δ
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
cmd/argo/commands/get.go 56.45% <0.00%> (-1.94%) ⬇️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddd420...0e02441. Read the comment docs.

@alexec alexec enabled auto-merge (squash) June 4, 2021 17:46
@alexec alexec merged commit 391cafb into argoproj:master Jun 4, 2021
@terrytangyuan terrytangyuan deleted the envvar-default-var branch June 4, 2021 17:54
@alexec alexec mentioned this pull request Jun 10, 2021
20 tasks
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants