Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Revert cb9676e88. Fixes #5852 #5933

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 18, 2021

This is a manual revert to v2.12

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review May 18, 2021 00:18
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #5933 (587d3c2) into master (f0540a9) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 587d3c2 differs from pull request most recent head d8de09b. Consider uploading reports for the commit d8de09b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5933      +/-   ##
==========================================
+ Coverage   47.36%   47.38%   +0.02%     
==========================================
  Files         247      247              
  Lines       15595    15605      +10     
==========================================
+ Hits         7386     7395       +9     
- Misses       7275     7279       +4     
+ Partials      934      931       -3     
Impacted Files Coverage Δ
workflow/controller/controller.go 19.82% <0.00%> (ø)
workflow/cron/controller.go 1.39% <0.00%> (-0.11%) ⬇️
workflow/controller/operator.go 70.52% <0.00%> (+0.27%) ⬆️
cmd/argo/commands/get.go 57.92% <0.00%> (+0.64%) ⬆️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0540a9...d8de09b. Read the comment docs.

@alexec alexec enabled auto-merge (squash) May 18, 2021 04:55
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue May 18, 2021 that may be closed by this pull request
@alexec alexec merged commit 56b71d0 into argoproj:master May 18, 2021
@alexec alexec deleted the fix branch May 18, 2021 22:35
@alexec alexec mentioned this pull request May 21, 2021
14 tasks
alexec added a commit that referenced this pull request May 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: 7x CPU usage
2 participants