Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installation): Enable capacity to override namespace with Kustomize #5907

Merged
merged 1 commit into from
May 17, 2021
Merged

fix(installation): Enable capacity to override namespace with Kustomize #5907

merged 1 commit into from
May 17, 2021

Conversation

Daverkex
Copy link
Contributor

@Daverkex Daverkex commented May 14, 2021

Checklist:

  • My organization is added to USERS.md.*
    *This is a personal PR

Tips:

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Fix: #4345
Continue: #4807, #4919

References:

@Daverkex Daverkex changed the title Enable capacity to override namespace with Kustomize fix: Enable capacity to override namespace with Kustomize May 14, 2021
@Daverkex Daverkex changed the title fix: Enable capacity to override namespace with Kustomize Enable capacity to override namespace with Kustomize May 14, 2021
@Daverkex Daverkex changed the title Enable capacity to override namespace with Kustomize Fix(installation): Enable capacity to override namespace with Kustomize May 14, 2021
@Daverkex Daverkex marked this pull request as ready for review May 14, 2021 10:45
@Daverkex Daverkex changed the title Fix(installation): Enable capacity to override namespace with Kustomize fix(installation): Enable capacity to override namespace with Kustomize May 14, 2021
Signed-off-by: Néstor García <nestor.garcia@navigaglobal.com>
@Daverkex Daverkex closed this May 15, 2021
@Daverkex Daverkex reopened this May 15, 2021
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #5907 (67d2549) into master (d009e6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5907   +/-   ##
=======================================
  Coverage   47.39%   47.39%           
=======================================
  Files         247      247           
  Lines       15596    15596           
=======================================
  Hits         7392     7392           
- Misses       7272     7273    +1     
+ Partials      932      931    -1     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 57.28% <0.00%> (-0.65%) ⬇️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d009e6b...67d2549. Read the comment docs.

@alexec alexec enabled auto-merge (squash) May 15, 2021 21:30
@alexec alexec merged commit 8fde4e4 into argoproj:master May 17, 2021
@alexec alexec mentioned this pull request May 21, 2021
14 tasks
alexec added a commit to alexec/argo-workflows that referenced this pull request Jun 5, 2021
… Kustomize (argoproj#5907)"

This reverts commit 8fde4e4.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest file install.yaml has incorrect ClusterRoleBindings.
2 participants